Make datadog message, escalation_message, and query work with heredoc #5788
+72
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
multilinear
force-pushed
the
mbrewer/datadog_allow_heredoc_for_message
branch
from
0113f8e
to
4fcb908
Compare
|
Nice one! LGTM |
|
👍 |
|
Is there anything else I should do? Or are we just waiting for someone with magic bits to wander by and click merge? |
|
@multilinear thanks for the PR - this looks good to me :) |
|
Thanks @stack72 |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote this patch for my own company (Meteor), after running in to the issue covered by:
#5642
This patch uses the same fix suggested there, just applied to a couple other relevant fields where heredocs are desirable. Datadog didn't seem to strip "name" based on my testing.
Here's the output from a run of the acceptance tests (including the one I'm adding)
==> Checking that code complies with gofmt requirements...
/usr/bin/stringer
go generate $(go list ./... | grep -v /vendor/)
TF_ACC=1 go test ./builtin/providers/datadog -v -timeout 120m
=== RUN TestProvider
--- PASS: TestProvider (0.00s)
=== RUN TestProvider_impl
--- PASS: TestProvider_impl (0.00s)
=== RUN TestAccDatadogMonitor_Basic
--- PASS: TestAccDatadogMonitor_Basic (97.48s)
=== RUN TestAccDatadogMonitor_Updated
--- PASS: TestAccDatadogMonitor_Updated (95.86s)
=== RUN TestAccDatadogMonitor_TrimWhitespace
--- PASS: TestAccDatadogMonitor_TrimWhitespace (68.40s)
PASS
ok github.com/hashicorp/terraform/builtin/providers/datadog 261.738s
Sorry if I missed anything... first time contributing to terraform :).